[Improvement][Seatunnel-web] Execute job REST API should be of type P…

…OST, not GET (#183)
apache · Aug 15, 2024 · d6f774d · d6f774d
1 parent 7205efe
commit d6f774d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/...eatunnel-app/src/main/java/org/apache/seatunnel/app/controller/JobExecutorController.java b/...eatunnel-app/src/main/java/org/apache/seatunnel/app/controller/JobExecutorController.java
@@ -25,6 +25,7 @@
 import org.apache.seatunnel.server.common.SeatunnelException;
 
 import org.springframework.web.bind.annotation.GetMapping;
+import org.springframework.web.bind.annotation.PostMapping;
 import org.springframework.web.bind.annotation.RequestAttribute;
 import org.springframework.web.bind.annotation.RequestMapping;
 import org.springframework.web.bind.annotation.RequestParam;
@@ -46,8 +47,8 @@ public class JobExecutorController {
     @Resource IJobExecutorService jobExecutorService;
     @Resource private IJobInstanceService jobInstanceService;
 
-    @GetMapping("/execute")
-    @ApiOperation(value = "Execute synchronization tasks", httpMethod = "GET")
+    @PostMapping("/execute")
+    @ApiOperation(value = "Execute synchronization tasks", httpMethod = "POST")
     public Result<Long> jobExecutor(
             @ApiParam(value = "userId", required = true) @RequestAttribute("userId") Integer userId,
             @ApiParam(value = "jobDefineId", required = true) @RequestParam("jobDefineId")

diff --git a/seatunnel-ui/src/service/sync-task-definition/index.ts b/seatunnel-ui/src/service/sync-task-definition/index.ts
@@ -317,7 +317,7 @@ export function sqlModelInfo(taskId: string, pluginId: string, data: any): any {
 export function executeJob(jobDefineId: number): any {
   return axios({
     url: `/job/executor/execute?jobDefineId=${jobDefineId}`,
-    method: 'get',
+    method: 'post',
     headers: {
       'Content-Type': 'application/json;charset=UTF-8'
     },

diff --git a/...eb-it/src/test/java/org/apache/seatunnel/app/controller/JobExecutorControllerWrapper.java b/...eb-it/src/test/java/org/apache/seatunnel/app/controller/JobExecutorControllerWrapper.java
@@ -26,7 +26,10 @@ public class JobExecutorControllerWrapper extends SeatunnelWebTestingBase {
 
     public Result<Long> jobExecutor(Long jobDefineId) {
         String response =
-                sendRequest(urlWithParam("job/executor/execute?jobDefineId=" + jobDefineId));
+                sendRequest(
+                        urlWithParam("job/executor/execute?jobDefineId=" + jobDefineId),
+                        "{}",
+                        "POST");
         return JSONTestUtils.parseObject(response, new TypeReference<Result<Long>>() {});
     }