-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve] [Seatunnel-Web] Add support for Seatunnel 2.3.6 in Seatunnel-Web #170
Conversation
Well done. It also works well with seatunnel tag 2.3.6. |
@hailin0, @hooklee2000 Thanks for your feedback. is there anything else I can do to get this PR merged. |
I will check why CI is failing. |
129dd89
to
ef6dc70
Compare
I have changed seatunnel version to 2.3.6. Now seatunnel-ui started failing in PR CI. Seems the failure not related to this change but need to find out root cause of build failure.
Does anybody have any idea on this build failure? |
@arshadmohammad Try this. |
ef6dc70
to
43fdda8
Compare
Thanks @twenty-zhang, the changes you suggested works fine. |
I will check why junit tests are failing with java 8 |
Seems Backend / Unit Test (8, ubuntu-latest) (pull_request) is failign becuase of CI environment issue, seatunnel-jackson-2.3.6-optional.jar; is corrupted |
43fdda8
to
e667c7a
Compare
pushed dummy change(added extra space in commit message) to retrigger the ci |
CI is passed :-) |
Thanks @Hisoka-X for reviewing and merging the PR. |
Purpose of this pull request
Add support for Seatunnel 2.3.5 in Seatunnel-Web.
Check list
New License Guide
Build seatunnel-web with the proposed the code changes, installed and verified that jobs are successfully executed on seatunnel 2.3.5 engines. Verification snapshot attached