Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] [Seatunnel-Web] Add support for Seatunnel 2.3.6 in Seatunnel-Web #170

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

arshadmohammad
Copy link
Collaborator

Purpose of this pull request

Add support for Seatunnel 2.3.5 in Seatunnel-Web.

Check list

Build seatunnel-web with the proposed the code changes, installed and verified that jobs are successfully executed on seatunnel 2.3.5 engines. Verification snapshot attached

image

@hooklee2000
Copy link

Well done. It also works well with seatunnel tag 2.3.6.

@arshadmohammad
Copy link
Collaborator Author

@hailin0, @hooklee2000 Thanks for your feedback. is there anything else I can do to get this PR merged.

@arshadmohammad
Copy link
Collaborator Author

I will check why CI is failing.

@arshadmohammad arshadmohammad force-pushed the seatunnel-2.3.5-support branch from 129dd89 to ef6dc70 Compare August 4, 2024 14:49
@arshadmohammad arshadmohammad changed the title [Improve] [Seatunnel-Web] Add support for Seatunnel 2.3.5 in Seatunnel-Web [Improve] [Seatunnel-Web] Add support for Seatunnel 2.3.6 in Seatunnel-Web Aug 4, 2024
@arshadmohammad
Copy link
Collaborator Author

I have changed seatunnel version to 2.3.6. Now seatunnel-ui started failing in PR CI. Seems the failure not related to this change but need to find out root cause of build failure.

[INFO] src/layouts/dashboard/index.tsx(75,40): error TS2339: Property '$route' does not exist on type 'CreateComponentPublicInstance<{}, { showSide: Ref<boolean, boolean>; menuKey: Ref<string, string>; }, {}, {}, {}, ComponentOptionsMixin, ComponentOptionsMixin, ... 12 more ..., {}>'.
Error: Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.11.3:npm (build) on project seatunnel-web-dist: Failed to run task: 'npm run build:prod' failed. org.apache.commons.exec.ExecuteException: Process exited with an error: 2 (Exit value: 2) -> [Help 1

Does anybody have any idea on this build failure?

@twenty-zhang
Copy link

twenty-zhang commented Aug 6, 2024

@arshadmohammad Try this.
<router-view key={this['$route'].fullPath} class={!this.showSide && 'px-32 py-12'} />

@arshadmohammad arshadmohammad force-pushed the seatunnel-2.3.5-support branch from ef6dc70 to 43fdda8 Compare August 6, 2024 11:43
@arshadmohammad
Copy link
Collaborator Author

Thanks @twenty-zhang, the changes you suggested works fine.
Most of the PR sanity checks are passed now
Build and verified the changes locally. installed seatunnel and seatunnel-web. created and executed on job. job executed successfully.

@arshadmohammad
Copy link
Collaborator Author

image

@arshadmohammad
Copy link
Collaborator Author

I will check why junit tests are failing with java 8

@arshadmohammad
Copy link
Collaborator Author

Seems Backend / Unit Test (8, ubuntu-latest) (pull_request) is failign becuase of CI environment issue, seatunnel-jackson-2.3.6-optional.jar; is corrupted
[INFO] ------------------------------------------------------------------------ Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project seatunnel-dynamicform: Compilation failure: Compilation failure: Error: [ERROR] error reading /home/runner/.m2/repository/org/apache/seatunnel/seatunnel-jackson/2.3.6/seatunnel-jackson-2.3.6-optional.jar; zip file is empty

@arshadmohammad arshadmohammad force-pushed the seatunnel-2.3.5-support branch from 43fdda8 to e667c7a Compare August 6, 2024 16:00
@arshadmohammad
Copy link
Collaborator Author

arshadmohammad commented Aug 6, 2024

pushed dummy change(added extra space in commit message) to retrigger the ci

@arshadmohammad
Copy link
Collaborator Author

CI is passed :-)

@Hisoka-X Hisoka-X merged commit 6155509 into apache:main Aug 7, 2024
15 checks passed
@arshadmohammad
Copy link
Collaborator Author

Thanks @Hisoka-X for reviewing and merging the PR.

@arshadmohammad arshadmohammad self-assigned this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants