Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][Seatunnel-web] Upgrade spring-boot version to 3.3.3 #213

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BilwaST
Copy link
Contributor

@BilwaST BilwaST commented Sep 10, 2024

Purpose of this pull request

Check list

@BilwaST
Copy link
Contributor Author

BilwaST commented Sep 11, 2024

Hi @Hisoka-X @arshadmohammad

Do we have plans to support jdk17? Spring-boot 3.3.3 needs jdk17 or later.

Internally i was working on implementing ldap/sso with seatunnel-web and found the incompatibilites with current spring boot and security jars which support the javax. Hence planned to upgrade the spring version.

@Hisoka-X
Copy link
Member

Do we have plans to support jdk17? Spring-boot 3.3.3 needs jdk17 or later.

Not for now. We should support jdk 17 on seatunnel first. Please trace apache/seatunnel#7086

@arshadmohammad
Copy link
Collaborator

Hi @Hisoka-X, are there any known issues preventing JDK 17 support in Seatunnel? is there any plan or timeline to support JDK 17 in seatunnel?

Hi @BilwaST, could you please verify if Seatunnel-web, compiled by JDK 17, functions correctly with Seatunnel compiled by JDK 8?

@Hisoka-X
Copy link
Member

Hi @Hisoka-X, are there any known issues preventing JDK 17 support in Seatunnel?

We plan to add hive3 e2e test case first. Then upgrade hadoop version and jdk version. apache/seatunnel#7474

is there any plan or timeline to support JDK 17 in seatunnel?

No. Depends on community progress

@BilwaST
Copy link
Contributor Author

BilwaST commented Nov 9, 2024

@arshadmohammad @Hisoka-X I have verified seatunnel-web compiled with jdk17 and seatunnel compiled with jdk8. It works fine. Can we first upgrade seatunnel-web to jdk17?

@Hisoka-X
Copy link
Member

Hisoka-X commented Nov 9, 2024

@arshadmohammad @Hisoka-X I have verified seatunnel-web compiled with jdk17 and seatunnel compiled with jdk8. It works fine. Can we first upgrade seatunnel-web to jdk17?

If this is done, doesn't it mean that users need to deploy two JDKs at the same time?

@BilwaST
Copy link
Contributor Author

BilwaST commented Nov 20, 2024

@arshadmohammad @Hisoka-X I have verified seatunnel-web compiled with jdk17 and seatunnel compiled with jdk8. It works fine. Can we first upgrade seatunnel-web to jdk17?

If this is done, doesn't it mean that users need to deploy two JDKs at the same time?

Yes. we need to deploy two JDKs at the same time. Otherwise we can add those hive e2e testcases and upgrade seatunnel's jdk version to 17.

@Hisoka-X
Copy link
Member

Otherwise we can add those hive e2e testcases and upgrade seatunnel's jdk version to 17.

yes, we already had add hive e2e testcase in apache/seatunnel#8003, waiting apache/seatunnel#7086. cc @liugddx

@BilwaST
Copy link
Contributor Author

BilwaST commented Nov 27, 2024

Hi @Hisoka-X

@liugddx has commented on the PR that he would be finishing it this week. Can we simultaneously work on upgrading it in seatunnel-web? Thank you

@Hisoka-X
Copy link
Member

Hi @Hisoka-X

@liugddx has commented on the PR that he would be finishing it this week. Can we simultaneously work on upgrading it in seatunnel-web? Thank you

we should waiting apache/seatunnel#7086 be merged, then merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants