Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][Seatunnel-web] Support H2 database in integration tests #219

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

arshadmohammad
Copy link
Collaborator

Purpose of this pull request

Check list

@arshadmohammad
Copy link
Collaborator Author

integration test execution result using default h2 database
image

@arshadmohammad
Copy link
Collaborator Author

integration test execution result using mysql data by passing -DdbType=mysql
image

@Hisoka-X Hisoka-X merged commit 5302b8c into apache:main Sep 27, 2024
15 checks passed
@arshadmohammad arshadmohammad self-assigned this Sep 27, 2024
@arshadmohammad
Copy link
Collaborator Author

Thanks @Hisoka-X for reviewing and merging this PR.

@arshadmohammad
Copy link
Collaborator Author

With the removal of the dependency on an external database, integration tests can now run using an in-memory H2 database. However, the Seatunnel distribution is still required.
@Hisoka-X, could you provide guidance on how to run the integration tests as part of the PR CI process?

@Hisoka-X
Copy link
Member

The test in CI in fact is trigger mvn script. Please refer https://github.com/apache/seatunnel/blob/dev/.github/workflows/backend.yml#L645

We already have some config in https://github.com/apache/seatunnel-web/blob/main/.github/workflows/backend.yml#L161
Just need add new script into backend.yml.

However, the Seatunnel distribution is still required.

We can execute mvn install before test with seatunnel-web.

  1. Checkout seatunnel dev branch, https://github.com/apache/seatunnel/blob/dev/.github/workflows/backend.yml#L86
  2. execute mvn install and other script which execute in local before. (Like set SEATUNNEL_HOME)
  3. Run mvn test by mvn script.
    all these step can be done with github action run https://github.com/apache/seatunnel/blob/dev/.github/workflows/backend.yml#L315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants