Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Seatunnel-web] Escape seatunnel-web placeholders #225

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

arshadmohammad
Copy link
Collaborator

  1. An option to escape placeholders in the configuration has been provided.
  2. If a placeholder is escaped by adding a backslash (e.g., ${valueParam:defaultValue}), it is passed to the Seatunnel engine as-is without value being replaced in Seatunnel-web.
  3. laceholders configured as default values in connectors are escaped before being displayed in the UI.

Purpose of this pull request

Check list

1. An option to escape placeholders in the configuration has been provided.
2. If a placeholder is escaped by adding a backslash (e.g., \${valueParam:defaultValue}), it is passed to the Seatunnel engine as-is without value being replaced in Seatunnel-web.
3. laceholders configured as default values in connectors are escaped before being displayed in the UI.
@arshadmohammad
Copy link
Collaborator Author

Handled Dead Link CI failures

@arshadmohammad
Copy link
Collaborator Author

Integration test execution
Screenshot from 2024-10-10 23-20-56

@arshadmohammad
Copy link
Collaborator Author

image

@arshadmohammad
Copy link
Collaborator Author

image

@Hisoka-X Hisoka-X merged commit ee399d2 into apache:main Oct 12, 2024
15 checks passed
@arshadmohammad arshadmohammad self-assigned this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants