Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [Seatunnel-web] Fix status always not runnning #246

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

xiaochen-zhou
Copy link
Contributor

@xiaochen-zhou xiaochen-zhou commented Dec 7, 2024

Purpose of this pull request

Fix: The status of seatunnel-web returned by the script seatunnel-backend-daemon.sh is always "not running"

image image

Check list

@xiaochen-zhou xiaochen-zhou changed the title [Fix][Connector-V2] Fix status always not runnning [Bug] Fix status always not runnning Dec 7, 2024
@xiaochen-zhou xiaochen-zhou changed the title [Bug] Fix status always not runnning [Bug] [Seatunnel-web] Fix status always not runnning Dec 7, 2024
@@ -74,7 +74,7 @@ stop() {

#status
status() {
pid=$(jcmd | grep -i 'seatunnel-app-.*jar' | grep -v grep | awk '{print $1}')
pid=$(jcmd | grep -i 'org.apache.seatunnel.app.SeatunnelApplication' | grep -v grep | awk '{print $1}')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, @xiaochen-zhou.
Could you also make additional modifications by changing seatunnel to seatunnel-web?
like below

if [ -n "$pid" ]; then
    echo "seatunnel-web is running"
  else
    echo "seatunnel-web is not running"
  fi

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, @xiaochen-zhou. Could you also make additional modifications by changing seatunnel to seatunnel-web? like below

if [ -n "$pid" ]; then
    echo "seatunnel-web is running"
  else
    echo "seatunnel-web is not running"
  fi

done.

Copy link
Collaborator

@arshadmohammad arshadmohammad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@arshadmohammad arshadmohammad merged commit 0fb6a65 into apache:main Dec 9, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants