Add case-insensitive name sorting support #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the fancyindex_case_sensitive option which considers the case when sorting by name if it is on (which it is by default to keep current behavior) and does a case-insensitive name sort if it is off. Closes aperezdc#78 Closes aperezdc#124 Co-authored-by: Ryan Schmidt <[email protected]>
aperezdc
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
@ryandesign Sorry again for being late with this review—indeed all the concerns are addressed now, thanks a ton!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to implement a case-insensitive sorting option to resolve #78 by modifying the code submitted in #124 to address the concerns in the comments.