Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OEV bot #4

Closed
wants to merge 1 commit into from
Closed

OEV bot #4

wants to merge 1 commit into from

Conversation

matejos
Copy link
Contributor

@matejos matejos commented Oct 3, 2024

Not to be merged! Only for discussion on changes from MEV with signed APIs bot to OEV bot.

@matejos matejos requested a review from Siegrift October 3, 2024 14:27
Copy link
Contributor

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's create a separate issue to fix this contract once the Api3ServerV1OevExtension contract gets an update.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean basically what the #5 does, right?

Copy link
Contributor

@Siegrift Siegrift Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but it seems we're not blocked by it anymore (I assume there is only a small chance the flow/contract is going to change).

src/beacons.ts Outdated Show resolved Hide resolved
Update Liquidator contract

Add pure liquidation function for simulating profit, refactor

Convenience contract updates

OEV bot

Fix beacon-related issues

Fix profit calculation

Report fulfillment

Cleanup on failed liquidation attempts

Add bidding phase buffer and use placeBidWithExpiration

Fix incorrect profit calculation

Reduce diff

Update API3 contracts

Update Liquidator contract and related

Code review update

Update Api3ServerV1OevExtension address

Updated Compound fork deployed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants