Fix 502 error when a menu link has a service and URL with a scheme

Error 502 happened if a menu link had a preconfigured service and a URL with a scheme set. Fixes #1394
apluslms · Aug 20, 2024 · 21e775f · 21e775f
1 parent 5733d53
commit 21e775f
Show file tree

Hide file tree

Showing 3 changed files with 257 additions and 201 deletions.
diff --git a/external_services/models.py b/external_services/models.py
@@ -300,6 +300,10 @@ def clean(self):
                 errors['menu_label'] = ValidationError(_(
                     'MENU_ITEM_ERROR_MENU_LABEL_REQUIRED_WHEN_NO_PRECONFIGURED_SERVICE_SELECTED'
                 ))
+        if self.service and self.menu_url and '://' in self.menu_url:
+            errors['menu_url'] = ValidationError(_(
+                'MENU_ITEM_ERROR_SCHEME_IN_MENU_URL_AND_PRECONFIGURED_SERVICE_SELECTED'
+            ))
         if errors:
             raise ValidationError(errors)