Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more info about max_points to points API #1380

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

etanttila
Copy link
Contributor

Description

What?
Add fields max_points and max_points_by_difficulty to the points API general information. This simplifies calculating relevant points in MOOC-Jutut. The max_points field was already provided in the API for modules, but not for the course as a whole, and the max points for each category/difficulty weren't in the API beforehand.

Why?

So viewing points via Jutut could work more efficiently

How?

Adding the fields max_points and max_points_by_difficulty to the API

Fixes #

Testing

Remember to add or update unit tests for new features and changes.

What type of test did you run?

  • Accessibility test using the WAVE extension.
  • Django unit tests.
  • Selenium tests.
  • Other test. (Add a description below)
  • Manual testing.

Tested locally that they appear in the API and the change works with the Jutut pull request

Did you test the changes in

  • Chrome
  • Firefox
  • This pull request cannot be tested in the browser.

Think of what is affected by these changes and could become broken

Translation

Programming style

  • Did you follow our style guides?
  • Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

  • documents inside the doc directory.
  • README.md.
  • Aplus Manual.
  • Other documentation (mention below which documentation).

Is it Done?

  • Reviewer has finished the code review
  • After the review, the developer has made changes accordingly
  • Customer/Teacher has accepted the implementation of the feature

Clean up your git commit history before submitting the pull request!

Add fields max_points and max_points_by_difficulty to the points API
general information. This simplifies calculating relevant points in
MOOC-Jutut. The max_points field was already provieded in the API for
modules, but not for the course as a whole, and the max points for
each category/difficulty weren't in the API beforehand.
Copy link
Contributor

@ihalaij1 ihalaij1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ihalaij1 ihalaij1 merged commit 53af490 into apluslms:master Jul 5, 2024
9 checks passed
@etanttila etanttila deleted the api-change-for-jutut branch July 9, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants