Add "regrade when notification seen" option #1383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added regrade_when_notification_seen field on submission requests to fix the issue where manually graded exercise points were being reset when a student read the related notification.
|
Accidentally tried to merge from my fork's master branch, closing this. New PR with same content in #1385. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue where manually graded exercise points were being reset when a student read a related notification. The change allows Jutut to still receive "message seen" info, as long as the param is set.
Testing
What type of test did you run?
Tested that Jutut (with the related change) can still mark messages as seen, and that manually graded exercises don't have their points reset.
Did you test the changes in