Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open menu links to external websites in a new tab #1393

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

ihalaij1
Copy link
Contributor

Description

What?

Open menu links to external websites, such as https://google.com in a new tab, instead of in the current tab.

Why?

This problem was pointed out by a teacher.

Fixes #1392

Copy link
Contributor

@murhum1 murhum1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine - having to assign the separate is_external_menu_url_flag variable just for one if statement feels a bit clunky, but at least according to a quick google search it doesn't look like there's a better alternative :/

@murhum1 murhum1 merged commit 0f546dc into apluslms:master Aug 23, 2024
9 checks passed
@ihalaij1
Copy link
Contributor Author

Seems to work fine - having to assign the separate is_external_menu_url_flag variable just for one if statement feels a bit clunky, but at least according to a quick google search it doesn't look like there's a better alternative :/

Yes, I tried to do it on one line first, but it didn't work...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Menu links to external websites should open in a new tab
2 participants