Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add courses where the user is an assistant to the API #1403

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

ihalaij1
Copy link
Contributor

Description

What?

Add courses where the user is an assistant to the API.
Previously, only the courses where the user is a teacher were listed in the API.

Why?

This was requested by a course.

Fixes #1397

@ihalaij1
Copy link
Contributor Author

We should agree on if renaming the old staff_courses to teacher_courses is okay, because it is a breaking change.

staff_courses seems confusing to me if assistants aren't included in it, since assistants are also considered staff.
We need a way to get only the teachers via the API for some other purposes, so including both in the same list isn't an option.

See the conversation here: #1397

@murhum1
Copy link
Contributor

murhum1 commented Sep 18, 2024

Could we include staff_courses as well, which would list courses where the user is a teacher or an assistant? That would also fix the issue for the course plugin without them having to make any changes, and would make sense.

Previously, only the courses where the user is a teacher
were listed in the API.

Fixes apluslms#1397
@ihalaij1
Copy link
Contributor Author

Made the changes! @murhum1

@murhum1 murhum1 merged commit 4a5c1d8 into apluslms:master Oct 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

List courses where the user is an assistant in the API
2 participants