Fix LTI tool issues #1405
Merged
Fix LTI tool issues #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murhum1
force-pushed
the
fix_lti_issues
branch
from
aa414d1 to
80e67fb
Compare
Added a confirmation dialog for importing the contents of a whole course via LTI in order to reduce the likelyhood of accidentally importing a whole course's worth of content. Also updated LTI module related views with correct classes when rewriting exercise links with lti-exercise URLs, since currently in production the isinstance calls don't match the module exercises.
murhum1
force-pushed
the
fix_lti_issues
branch
from
80e67fb to
a94aed1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a confirmation dialog for importing the contents of a whole course via LTI in order to reduce the likelyhood of accidentally importing a whole course's worth of content.
Also updated LTI module related views with correct classes when rewriting exercise links with lti-exercise URLs, since currently in production the isinstance calls don't match the module exercises.
Testing
What type of test did you run?
Tested that importing courses and navigating to exercises from modules works.
Tested that the confirmation popup is shown when trying to import the whole course.
Did you test the changes in
Translation