Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more data to info.csv from zip download #1429

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

mikaelGusse
Copy link
Contributor

Description

What?

Added some columns to the info.csv. These are useful for the ImGPT tool as well as Radar/Dolos.

Why?

See above

How?

Added rows. All things are fetched through database queries. Seems quite fast from my testing

Fixes #1427

Testing

Remember to add or update unit tests for new features and changes.

What type of test did you run?

  • Accessibility test using the WAVE extension.
  • Django unit tests.
  • Selenium tests.
  • Other test. (Add a description below)
  • Manual testing.

[ADD A DESCRIPTION ABOUT WHAT YOU TESTED MANUALLY]

Did you test the changes in

  • Chrome
  • Firefox
  • This pull request cannot be tested in the browser.

Think of what is affected by these changes and could become broken

Translation

Programming style

  • Did you follow our style guides?
  • Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

  • documents inside the doc directory.
  • README.md.
  • Aplus Manual.
  • Other documentation (mention below which documentation).

Is it Done?

  • Reviewer has finished the code review
  • After the review, the developer has made changes accordingly
  • Customer/Teacher has accepted the implementation of the feature

Clean up your git commit history before submitting the pull request!

@mikaelGusse mikaelGusse requested a review from murhum1 December 17, 2024 08:15
Copy link
Contributor

@murhum1 murhum1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried this out - at least my libreoffice calc defaults use semicolon as a column separator, so with multiple submitters / multiple files in a submission, the columns get messed up. That's fixable on the user end though by disallowing semicolons as separators, so I figure that's fine for now at least. Works fine otherwise!

@murhum1 murhum1 merged commit 3a374cf into apluslms:master Dec 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New fields for the ZIP download csv
2 participants