Fix total conversation count when paginated #111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the total conversation count still was only the number of conversations on the displayed page. Change the total_conversation_count to actually have all of the filtered conversations (not just the ones on the page.)
Description
What?
Previously the total conversation count still was only the number of conversations on the displayed page. Change the total_conversation_count to actually have all of the filtered conversations (not just the ones on the page.)
Why?
#103 didn't actually solve the total conversation count issue.
How?
Changing where the total_conversation_count variable is calculated (to PaginationMixin) and changing that it calcluates the total count using all of the messages, not just the ones provided in the context.
Fixes #94
Testing
Remember to add or update unit tests for new features and changes.
What type of test did you run?
Tested that works with different paginate_by values with different message and conversations counts were above 60, 90 and 120.
Did you test the changes in
Think of what is affected by these changes and could become broken
Translation
Programming style
Have you updated the README or other relevant documentation?
Is it Done?
Clean up your git commit history before submitting the pull request!