fix: Support new error type for persisted query publish #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glasser
reviewed
Aug 2, 2023
| @@ -6,6 +6,9 @@ mutation PublishOperationsMutation($graphId: ID!, $listId: ID!, $operationManife | |||
| ... on PermissionError { | |||
| message | |||
| } | |||
| ... on CannotModifyOperationBodyError { | |||
There was a problem hiding this comment.
Just for posterity, a better thing to do here would be ... on Error but graphql-client seems to disallow that :( graphql-rust/graphql-client#454
glasser
approved these changes
Aug 2, 2023
Merged
dbanty
added a commit
that referenced
this pull request
Aug 2, 2023
## 🚀 Features - **Support binary mirrors via the npm installer - @LongLiveCHIEF, #1675** When installing Rover via npm, you can override the base URL where Rover binaries are downloaded from in one of two ways: - by setting the `APOLLO_ROVER_DOWNLOAD_HOST` environment variable - by adding the following to your global or local `.npmrc`: ```ini apollo_rover_download_host=https://your.mirror.com/repository ``` This enables installing Rover when `https://rover.apollo.dev` is unavailable, for example, in a private network. ## 🐛 Fixes - **Improve error handling for `persisted-queries publish` - @dbanty, #1697** ## 📚 Documentation - **Clarify that `routing_url` is optional when using a graph ref with `rover dev` - @smyrick, #1683** --------- Co-authored-by: Dylan Anthony <[email protected]> Co-authored-by: Maria Elisabeth Schreiber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes what appears to be accidental duplicate code.