Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update the Dependencies section #848

Merged
merged 2 commits into from
Oct 19, 2024
Merged

docs: Update the Dependencies section #848

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2618f13
docs: Update the Dependencies section
Dor-bl Oct 18, 2024
e278d11
Remove System.Text.Json from Dependencies list
Dor-bl Oct 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,13 @@ App management: Please read [issue #15807](https://github.com/appium/appium/issu

## NuGet

NuGet Package: [](http://www.nuget.org/packages/Appium.WebDriver/)
[NuGet Package](http://www.nuget.org/packages/Appium.WebDriver/)

Dependencies:

- [Selenium.WebDriver](http://www.nuget.org/packages/Selenium.WebDriver/)
- [Newtonsoft.Json](http://www.nuget.org/packages/Newtonsoft.Json/)
- [Selenium.Support](https://www.nuget.org/packages/Selenium.Support/)
- [Castle.Core](https://www.nuget.org/packages/Castle.Core/)
- [System.Text.Json](https://www.nuget.org/packages/System.Text.Json/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this here? As this project, this deps is maybe for testing only

dotnet-client/test/integration/Appium.Net.Integration.Tests.csproj

Line 19 in dfb65ac

<PackageReference Include="System.Text.Json" Version="8.0.5" />

I'm wondering if this deps can have a link to https://github.com/appium/dotnet-client/blob/main/src/Appium.Net/Appium.Net.csproj simply for product code, and test code is dotnet-client/test/integration/Appium.Net.Integration.Tests.csproj instead of listening all of them here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right, removed System.Text.Json.
Regarding the link, I can add the following link which will show the NuGet dependencies
https://www.nuget.org/packages/Appium.WebDriver/absoluteLatest#dependencies-body-tab

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KazuCocoa, so what's your call, Add the link to NuGet dependencies tab?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either is fine. I mean maintaining the deps here as well, or leaving the link only so that we don't need to keep reflecting the deps

- [System.Drawing.Common](https://www.nuget.org/packages/System.Drawing.Common/)

Note: we will NOT publish a signed version of this assembly since the dependencies we access through NuGet do not have a signed version - thus breaking the chain and causing us headaches. With that said, you are more than welcome to download the code and build a signed version yourself.

Expand All @@ -90,8 +89,8 @@ Note: we will NOT publish a signed version of this assembly since the dependenci

- You need to add the following namespace line: `using OpenQA.Selenium.Appium;`.
- Use the `AppiumDriver` class/subclass to construct the driver. It works the same as the Selenium Webdriver, except that
the ports are defaulted to Appium values, and the driver does not know how to start the Appium independently.
- To use the Appium methods on Element, you need to specify the parameter of `AppiumDriver` or its subclasses.
the ports default to Appium values, and the driver does not know how to start the Appium independently.
- To use the Appium methods on Element, specify the parameter of `AppiumDriver` or its subclasses.

[Read Wiki](https://github.com/appium/appium-dotnet-driver/wiki)

Expand Down