Build out the validation of google.protobuf.Any JSON support. #1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasvl
force-pushed
the
json_encoding_checks
branch
from
e295e4e to
99f5cd1
Compare
The upstream major languages directly use their type registries to eagerly validate `type_url`s. This means they will fail to decode or encode JSON for a lot of cases. The conformance tests only cover some of this so I hacked in some C++ unittests to see what errors are thrown and then made the matching cases here and expanded our error handling to duplicate the results. The bulk of the changes are really just update comments to cover what errors are now throw (not actual code changes).
thomasvl
force-pushed
the
json_encoding_checks
branch
from
99f5cd1 to
f55b5db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream major languages directly use their type registries to eagerly validate
type_urls. This means they will fail to decode or encode JSON for a lot of cases.The conformance tests only cover some of this so I hacked in some C++ unittests to see what errors are thrown and then made the matching cases here and expanded our error handling to duplicate the results.
The bulk of the changes are really just update comments to cover what errors are now throw (not actual code changes).