This repository has been archived by the owner on Jun 21, 2022. It is now read-only.
feat: support stdin #95
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simar7
reviewed
Mar 18, 2020
| @@ -69,6 +73,16 @@ func NewImage(ctx context.Context, image Reference, transports []string, option | |||
| auth = GetToken(ctx, domain, option) | |||
| } | |||
|
|
|||
| // Receive an image content from stdin | |||
| var tmpImageFileName string | |||
| if image.IsFile && image.Name == "-" && !terminal.IsTerminal(0) { | |||
There was a problem hiding this comment.
Is there a way to set something up so that !terminal.IsTerminal(0) can evaluate to true in a test? If so we should add a test for it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fanal supported
-to take an image content from stdin before, but the feature was dropped when moving tocontainers/image. But some users want this feature, so this PR makes it possible to do it again.Related to aquasecurity/trivy#418
For example,