Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jaredoconnell committed Oct 1, 2024
1 parent 0ad791b commit 4f545d5
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion cli_plugin.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ func (p *CliPlugin) Close() error {
killErr = p.wrapper.Kill(p.containerName)
}

// Still clean up even if the kill fails.
// Still clean up even if the kill fails. Clean() uses the --force parameter, so that
// will be another attempt at killing the container.
cleanErr := p.wrapper.Clean(p.containerName)

if err := p.stdin.Close(); err != nil {
Expand Down

0 comments on commit 4f545d5

Please sign in to comment.