wip: force open modals

arduino · Nov 26, 2024 · c436769 · c436769
1 parent b8f1d8a
commit c436769
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/arduino-ide-extension/src/browser/contributions/check-for-ide-updates.ts b/arduino-ide-extension/src/browser/contributions/check-for-ide-updates.ts
@@ -7,6 +7,7 @@ import {
 } from '../../common/protocol/ide-updater';
 import { IDEUpdaterDialog } from '../dialogs/ide-updater/ide-updater-dialog';
 import { Contribution } from './contribution';
+import { VersionWelcomeDialog } from '../dialogs/version-welcome-dialog';
 
 @injectable()
 export class CheckForIDEUpdates extends Contribution {
@@ -16,6 +17,9 @@ export class CheckForIDEUpdates extends Contribution {
   @inject(IDEUpdaterDialog)
   private readonly updaterDialog: IDEUpdaterDialog;
 
+  @inject(VersionWelcomeDialog)
+  private readonly welcomeDialog: VersionWelcomeDialog;
+
   @inject(LocalStorageService)
   private readonly localStorage: LocalStorageService;
 
@@ -49,6 +53,7 @@ export class CheckForIDEUpdates extends Contribution {
         return this.updater.checkForUpdates(true);
       })
       .then(async (updateInfo) => {
+        this.welcomeDialog.open();
         if (!updateInfo) return;
         const versionToSkip = await this.localStorage.getData<string>(
           SKIP_IDE_VERSION

diff --git a/arduino-ide-extension/src/electron-main/ide-updater/ide-updater-impl.ts b/arduino-ide-extension/src/electron-main/ide-updater/ide-updater-impl.ts
@@ -62,7 +62,7 @@ export class IDEUpdaterImpl implements IDEUpdater {
       await this.updater.checkForUpdates();
 
     this.cancellationToken = cancellationToken;
-    if (this.updater.currentVersion.compare(updateInfo.version) === -1) {
+    if (true) {
       /*
         'latest.txt' points to the latest changelog that has been generated by the CI,
         so we need to make a first GET request to get the filename of the changelog