implement callbacks #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taitruong
reviewed
Nov 19, 2023
| /// You must verify this message was called by an approved ICS721 contract, either by code_id or address. | ||
| #[cw_serde] | ||
| pub struct Ics721ReceiveMsg { | ||
| pub original_packet: NonFungibleTokenPacketData, |
There was a problem hiding this comment.
I'd just name it packet or nft_data.
There was a problem hiding this comment.
I would like to keep the original here, to make it obvious that this is the original packet that was sent, and not anything else.
taitruong
reviewed
Nov 19, 2023
packages/ics721/src/types.rs
Outdated
| /// Being called on receiving the NFT after transfer was completed. (destination side) | ||
| /// `on_recieve` hook | ||
| /// Note - Failing this message will fail the transfer. | ||
| ReceiveNftIcs721(Ics721ReceiveMsg), |
There was a problem hiding this comment.
Would rename this to Ics721ReceiveNft.
Would also rename:
Ics721Callback -> Ics721CallbackNft
Ics721ReceiveMsg -> Ics721ReceiveNftMsg
Ics721CallbackMsg -> Ics721CallbackNftMsg
Would make naming more consistent.
Out of consistenty
There was a problem hiding this comment.
What you think about this:
pub enum ReceiverExecuteMsg {
Ics721ReceiveCallback(Ics721ReceiveCallbackMsg),
Ics721AckCallback(Ics721AckCallbackMsg),
}
I want to make it clear we have 2 type of callbacks (hooks).
- Receive callback: is being called on the target (receiver) chain, after NFT was transferred successfully.
- Ack callback: is being called on the source (sender) chain after transfer, letting the contract know of the status of the transfer (succeed or failed).
taitruong
reviewed
Nov 19, 2023
|
LGTM. Only minor renaming suggestions - for better understanding. |
…props are optional
… additional custom data
…data CollectionData with minimal props, name and symbol, all others are optional.
taitruong
reviewed
Nov 23, 2023
taitruong
reviewed
Nov 23, 2023
taitruong
reviewed
Nov 24, 2023
taitruong
reviewed
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10