e2e tests folder restructure #14
Conversation
e2e/callback_test.go
Outdated
| require.Error(suite.T(), err) | ||
| } | ||
|
|
||
| func callbackMemo(srcCallback, srcReceiver, dstCallback, dstReceiver string) string { |
There was a problem hiding this comment.
I'd prefer using same namings as it is used for props. like srcCallback -> ack_callback_data, etc.
e2e/callback_test.go
Outdated
| } | ||
|
|
||
| func sendIcsFromChainAToB(suite *CallbackTestSuite, nft, tokenId, memo string, relay bool) { | ||
| msg := fmt.Sprintf(`{ "send_nft": {"cw721": "%s", "ics721": "%s", "token_id": "%s", "recipient":"%s", "channel_id":"%s", "memo":"%s"}}`, nft, suite.bridgeA.String(), tokenId, suite.testerB.String(), suite.pathAB.EndpointA.ChannelID, memo) |
There was a problem hiding this comment.
What happens if memo is empty? Memo is an optional prop.
e2e/callback_test.go
Outdated
| return b64.StdEncoding.EncodeToString([]byte(memo)) | ||
| } | ||
|
|
||
| func nftSentCb() string { |
There was a problem hiding this comment.
better rename to create_ack_callback_data
e2e/callback_test.go
Outdated
| return b64.StdEncoding.EncodeToString([]byte(`{ "nft_sent": {}}`)) | ||
| } | ||
|
|
||
| func nftReceivedCb() string { |
There was a problem hiding this comment.
rename: create_receive_callback_data
| return r | ||
| } | ||
|
|
||
| func GetCw721SendIbcAwayMessage(path *wasmibctesting.Path, coordinator *wasmibctesting.Coordinator, tokenId string, bridge, receiver sdk.AccAddress, timeout int64, memo string) string { |
There was a problem hiding this comment.
GetCw721SendIbcAwayMessage -> CreateSendNftWithIbcOutgoingMsg
| ibcAway := fmt.Sprintf(`{ "receiver": "%s", "channel_id": "%s", "timeout": { "timestamp": "%d" }, "memo": %s }`, receiver.String(), path.EndpointA.ChannelID, timeout, memo) | ||
| ibcAwayEncoded := b64.StdEncoding.EncodeToString([]byte(ibcAway)) |
There was a problem hiding this comment.
ibcAway -> ibcOutgoingMsg
ibcAwayEncoded -> ibcOutgoingMsgEncoded
e2e/test_suite/actions.go
Outdated
| require.NoError(t, err) | ||
| } | ||
|
|
||
| func Ics721TransferNft(t *testing.T, chain *wasmibctesting.TestChain, path *wasmibctesting.Path, coordinator *wasmibctesting.Coordinator, nft string, tokenId string, bridge, sender, receiver sdk.AccAddress, memo string) *sdk.Result { // Send the NFT away. |
There was a problem hiding this comment.
Ics721TransferNft -> Ics721SendNft
| memo := callbackMemo(nftSentCb(), "", nftReceivedCb(), "") | ||
| // A -> B token_id 2 |
There was a problem hiding this comment.
What's the difference between sendIcsFromChainAToB and test_suite.Ics721TransferNft? Seems to lookalike
| require.Equal(suite.T(), testerDataOwnerB, suite.testerB.String()) | ||
| } | ||
|
|
||
| func (suite *CbTestSuite) TestSuccessfulTransferWithReceivers() { | ||
| func (suite *CallbackTestSuite) TestSuccessfulTransferWithReceivers() { |
There was a problem hiding this comment.
This test has same result as for TestSuccessfulTransfer. By its name, I wouldnt know what it actually tests. As far as I see only difference is, by memo, where addresses are provided in one and not provided by other test:
TestSuccessfulTransferWithReceivers:
memo := callbackMemo(nftSentCb(), suite.testerA.String(), nftReceivedCb(), suite.testerB.String())
TestSuccessfulTransfer:
memo := callbackMemo(nftSentCb(), "", nftReceivedCb(), "")
| require.Equal(suite.T(), chainBOwner, suite.testerB.String()) | ||
|
|
||
| // We query the data we have on the tester contract | ||
| // This ensures that the callbacks are called after all the messages was completed | ||
| // and the transfer was successful | ||
| testerDataOwnerA := queryTesterSent(suite.T(), suite.chainA, suite.testerA.String()) | ||
| testerDataOwnerA := test_suite.QueryTesterSent(suite.T(), suite.chainA, suite.testerA.String()) |
There was a problem hiding this comment.
Not clear to me, how below 3 assertions work. In case ack and receive addr is empty in callback, then ack callback is called on sender on chain A, and receive callback is called on recipient. So some kind of result data is check and verified on sender and recipient (contract?)?
|
@magiodev great job! thx a lot! |
This PR reorganizes the e2e tests for better structure and reuse of helper functions.
Changes
test_suitePackage:test_suitefolder.suite_helpers.gointo several context-specific files intest_suite.full_test.gowithbasic_test.go, using the new test suite structure.