-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ID Token Validation in OIDC flows. #4
Comments
Encrypted ID Tokens are not supporting ATM. Hence this point is NA as of now. Adding the support of encrypted ID Tokens are tracked with #3. |
Verification is in place at https://bitbucket.org/connect2id/oauth-2.0-sdk-with-openid-connect-extensions/src/354fd08849407cb5b1fe26026c01bba3e647c096/src/main/java/com/nimbusds/openid/connect/sdk/validators/IDTokenClaimsVerifier.java#lines-172. Tested manually and confirmed. |
Verification for, "The Client MUST validate that the aud (audience) Claim contains its client_id value registered at the Issuer identified by the iss (issuer) Claim as an audience." , is in place at https://bitbucket.org/connect2id/oauth-2.0-sdk-with-openid-connect-extensions/src/354fd08849407cb5b1fe26026c01bba3e647c096/src/main/java/com/nimbusds/openid/connect/sdk/validators/IDTokenClaimsVerifier.java#lines-186. Tested manually and confirmed. |
Verification is in place at https://github.com/ChamathNS/asgardio-java-oidc-sdk/blob/324e1c62bff52958b611527674cda6746fe531c2/io.asgardio.java.oidc.sdk/src/main/java/io/asgardio/java/oidc/sdk/OIDCManagerImpl.java#L249. Tested manually and confirmed. (Update link once merged.) |
Verification is in place at https://bitbucket.org/connect2id/oauth-2.0-sdk-with-openid-connect-extensions/src/368d830e49f0f0a30cee7ae80c6bedcdb8ebfa49/src/main/java/com/nimbusds/openid/connect/sdk/validators/IDTokenClaimsVerifier.java#lines-202. Tested manually and confirmed. |
Verification is in place at https://bitbucket.org/connect2id/nimbus-jose-jwt/src/f35500971243460a1e044357f04202e626c4825a/src/main/java/com/nimbusds/jwt/proc/DefaultJWTProcessor.java#lines-383. Tested manually and confirmed. |
Verification is at https://github.com/ChamathNS/asgardio-java-oidc-sdk/blob/c91a7e9ff68919b24382d0ec78164209c6f35053/io.asgardio.java.oidc.sdk/src/main/java/io/asgardio/java/oidc/sdk/OIDCManagerImpl.java#L282-L292. Tested manually and confirmed. (Update link once merged.) |
Verification is at https://bitbucket.org/connect2id/nimbus-jose-jwt/src/master/src/main/java/com/nimbusds/jose/jwk/source/ImmutableSecret.java#lines-47 and https://bitbucket.org/connect2id/nimbus-jose-jwt/src/d65f9ffd13616ee1f9f1a4672d0e84dd7e7a7669/src/main/java/com/nimbusds/jwt/proc/DefaultJWTProcessor.java#lines-384. Tested manually and confirmed. |
Verification is in place at https://bitbucket.org/connect2id/oauth-2.0-sdk-with-openid-connect-extensions/src/368d830e49f0f0a30cee7ae80c6bedcdb8ebfa49/src/main/java/com/nimbusds/openid/connect/sdk/validators/IDTokenClaimsVerifier.java#lines-224. Tested manually and confirmed. |
This behavior is not currently supported. Adding support for |
Validation is in place at https://bitbucket.org/connect2id/oauth-2.0-sdk-with-openid-connect-extensions/src/368d830e49f0f0a30cee7ae80c6bedcdb8ebfa49/src/main/java/com/nimbusds/openid/connect/sdk/validators/IDTokenClaimsVerifier.java#lines-248. Tested manually and confirmed. |
There is no support for |
This improvement is tracked by #9. |
Description:
In the oidc-sdk, its need to validate the ID Token as per the openid-connect spec [1]. Listing the points below for the ease of reference.
Need to test whether each of above points are covered by the SDK flow.
[1] - https://openid.net/specs/openid-connect-core-1_0.html#IDTokenValidation
The text was updated successfully, but these errors were encountered: