Add Id token validation fix and HTTP Session Wrapper for the OIDC Manger. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chamathns
force-pushed
the
id-token-validation-fix
branch
from
999e40f to
e4f87c7
Compare
gayashanbc
reviewed
Nov 10, 2020
|
|
||
| return new org.powermock.modules.testng.PowerMockObjectFactory(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Resolved with 8935b73.
...gardio.java.oidc.sdk/src/main/java/io/asgardio/java/oidc/sdk/request/OIDCRequestBuilder.java
Show resolved
Hide resolved
|
|
||
| closeJadler(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Resolved with 8935b73.
chamathns
commented
Nov 11, 2020
|
|
||
| closeJadler(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Resolved with 8935b73.
chamathns
commented
Nov 11, 2020
|
|
||
| return new org.powermock.modules.testng.PowerMockObjectFactory(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Resolved with 8935b73.
gayashanbc
approved these changes
Nov 11, 2020
darshanasbg
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Related PRs
resolves #4