fix: Fix issues in Ash.Generator.generate_many/2
#1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevenseacat
force-pushed
the
generate_many_fixes
branch
from
f367544 to
b5f4b10
Compare
…rating many records This prevents warnings in tests when using `generate_many` - `[warning] Missed <x> notifications in action <action>`
…n `generate_many` wasn't a complete success A partial success would mean less records were inserted than were requested, definitely leading to buggy/flaky tests
zachdaniel
reviewed
Jan 9, 2025
| @@ -505,12 +505,27 @@ defmodule Ash.Generator do | |||
| fn _changeset, record -> | |||
| {:ok, after_action.(record)} | |||
| end | |||
| else | |||
| # Do nothing | |||
| fn _changeset, record -> {:ok, record} end | |||
There was a problem hiding this comment.
I'll merge but I'm going to figure out how to make this not necessary, as adding hooks that aren't needed can prevent internal optimizations etc.
|
🚀 Thank you for your contribution! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing out
generate_many/2I found there were a couple of issues with it:after_action: nilwas passed tobulk_createbulk_create(instead of just the action name)bulk_createrequired authorization (no actor being passed in)bulk_creategenerated any notifications (tbh I'm not sure why the action I'm testing with is generating notifications, but that's a different story)With these changes I can successfully call
generate_manylikegenerate_many(artist(), 2)and get two Artist records back.