Skip to content

Commit

Permalink
PHP 8 Support (#83)
Browse files Browse the repository at this point in the history
* PHP 8 Support

* Fix whitespace issue

* Run builds on Pull Requests
  • Loading branch information
driesvints authored Oct 29, 2020
1 parent 88aaf08 commit 8d8f88b
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
on:
push:
pull_request:
schedule:
- cron: '0 0 * * *'

Expand All @@ -9,7 +10,7 @@ jobs:

strategy:
matrix:
php: [7.4, 7.3, 7.2, 7.1, 7.0]
php: [8.0, 7.4, 7.3, 7.2, 7.1, 7.0]
dependency-version: [prefer-lowest, prefer-stable]
os: [ubuntu-latest]

Expand All @@ -34,4 +35,4 @@ jobs:

- name: Check PSR-12 Codestyle
run: vendor/bin/phpcs --standard=psr12 src/
if: matrix.os == 'ubuntu-latest'
if: matrix.os == 'ubuntu-latest'
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
}
],
"require": {
"php": "^7.0",
"php": "^7.0|^8.0",
"symfony/http-foundation": "~2.7|~3.0|~4.0|~5.0",
"symfony/http-kernel": "~2.7|~3.0|~4.0|~5.0"
},
Expand Down
2 changes: 1 addition & 1 deletion src/CorsService.php
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public function handlePreflightRequest(Request $request): Response
public function addPreflightRequestHeaders(Response $response, Request $request): Response
{
$this->configureAllowedOrigin($response, $request);

if ($response->headers->has('Access-Control-Allow-Origin')) {
$this->configureAllowCredentials($response, $request);

Expand Down

0 comments on commit 8d8f88b

Please sign in to comment.