Handle multi-threaded BEPEventCallback calls #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that this plugin is updated to depend on Aspect CLI v1.202449.18 (#4), it can be opted into
multi_threaded_build_eventsfor improved BES processing performance. When it is, it must handle concurrent calls toBEPEventCallbackthat may come in out-of-order of sequence number. See commit description of aspect-build/aspect-cli@082f7af for more details.This PR sets up a
besChanto pipe ordered build events into and a single go routine to process them in order. ThePostBuildHookcloses the channel and waits on thebesHandlerWaitGroupto complete.