Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test case for sourceMaps set in swcrc. #282

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aptenodytes-forsteri
Copy link

@aptenodytes-forsteri aptenodytes-forsteri commented Nov 4, 2024

Currently, the rules always set sourceMaps on the command line, overriding whatever is in swcrc. This can be confusing if we attempt to set sourceMaps in swcrc.

See #283


Changes are visible to end-users: yes/no

  • Searched for relevant documentation and updated as needed: yes/no
  • Breaking change (forces users to change their own code or config): yes/no
  • Suggested release notes appear below: yes/no

Test plan

  • Covered by existing test cases
  • New test cases added
  • Manual testing; please provide instructions so we can reproduce:

Currently, the rules always set sourceMaps on the command line,
overriding whatever is in swcrc. This can be confusing if we attempt to
set sourceMaps in swcrc.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants