Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add large_pillows tumble dryer program #228

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Conversation

apeeters
Copy link
Contributor

Required for full TCR790WP mapping.

@astrandb
Copy link
Owner

astrandb commented Mar 4, 2023

We need the raw value presented by the API also. Please capture a diagnostic download from the device page when running the large pillows program.

@aturri
Copy link
Contributor

aturri commented Mar 4, 2023

Hi, it's mapped on 20, so it is in conflict with an existing program.

@astrandb
Copy link
Owner

Stale. closing

@astrandb astrandb closed this Nov 20, 2023
@apeeters
Copy link
Contributor Author

apeeters commented Nov 22, 2023

@astrandb this issue is still valid. As @aturri mentioned, the raw value is 20:

      "ident|deviceIdentLabel|techType": "TCR790WP",
      "state|ProgramID|value_raw": 20,
      "state|ProgramID|value_localized": "Large pillows",
      "state|ProgramID|key_localized": "Program name",

Which indeed conflicts with the existing cottons program. This is why the unmapped_5 entry is needed: to allow local Localization override.

@astrandb astrandb reopened this Nov 22, 2023
Copy link
Owner

@astrandb astrandb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry that this PR has been forgotten.

"large_pillows": "Large pillows", should be added to translations/en.json
The other languages will be handled in Lokalise by our team of translators.

Copy link
Owner

@astrandb astrandb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @apeeters .

@astrandb astrandb merged commit 919398f into astrandb:main Nov 27, 2023
3 checks passed
@astrandb astrandb added enhancement New feature or request and removed additional info requested labels Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants