Option for exclude default build deps #134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jean-helsinki
force-pushed
the
option_exclude_default_build_deps
branch
2 times, most recently
from
d22148a to
d90a337
Compare
jean-helsinki
changed the title
dirk-thomas
force-pushed
the
option_exclude_default_build_deps
branch
from
d90a337 to
7386d05
Compare
dirk-thomas
reviewed
Dec 3, 2019
dirk-thomas
reviewed
Dec 3, 2019
|
@jean-helsinki Friendly ping. |
jean-helsinki
force-pushed
the
option_exclude_default_build_deps
branch
from
7386d05 to
7c85766
Compare
dirk-thomas
reviewed
May 18, 2020
| @@ -879,6 +879,15 @@ def __init__(self, | |||
| else: | |||
| build_deps.append( 'debhelper (>= %s)'%DH_MIN_VERS ) | |||
|
|
|||
| try: | |||
| no_default_build_deps = \ | |||
| cfg.get('DEFAULT', 'No-Default-Build-Deps')\ | |||
There was a problem hiding this comment.
Instead of accessing the config directly this should use parse_val() instead.
Please document the new configuration option in the README.
|
@jean-helsinki Friendly ping. |
|
Closing due to no response from the author. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for issue #133