-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply TestContainer #264
Merged
Apply TestContainer #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added the bug label because the absence of fine-grained database versioning fails to cover conditional test cases. |
This PR is in very early phase of the changes |
TODO
|
TODO
|
jchrys
force-pushed
the
1x-tc
branch
2 times, most recently
from
April 2, 2024 19:11
0385f0b
to
c2ae9a5
Compare
jchrys
force-pushed
the
1x-tc
branch
2 times, most recently
from
April 2, 2024 19:46
f5de078
to
b47dbf1
Compare
mirromutth
requested changes
Apr 3, 2024
r2dbc-mysql/src/test/java/io/asyncer/r2dbc/mysql/internal/util/TestContainerExtension.java
Outdated
Show resolved
Hide resolved
r2dbc-mysql/src/test/java/io/asyncer/r2dbc/mysql/internal/util/TestContainerExtension.java
Show resolved
Hide resolved
r2dbc-mysql/src/test/java/io/asyncer/r2dbc/mysql/SessionStateIntegrationTest.java
Show resolved
Hide resolved
r2dbc-mysql/src/test/java/io/asyncer/r2dbc/mysql/internal/util/TestContainerExtension.java
Outdated
Show resolved
Hide resolved
r2dbc-mysql/src/test/java/io/asyncer/r2dbc/mysql/ZstdCompressionIntegrationTest.java
Show resolved
Hide resolved
jchrys
force-pushed
the
1x-tc
branch
2 times, most recently
from
April 3, 2024 11:48
4a9e8f3
to
9eaa3c5
Compare
Motivation: Enhance test reliability and environment consistency by integrating TestContainers Modification: Added TestContainers dependency and updated tests to run with containerized DBs. Expanded test scope to include MySQL and MariaDB versions to cover conditional test cases. Result: Improved test suite stability and simplified setup for contributors. Resolves #76 --------- Co-authored-by: saurabhyadav1985 <[email protected]> Co-authored-by: Mirro Mutth <[email protected]>
mirromutth
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Enhance test reliability and environment consistency by integrating TestContainers
Modification:
Added TestContainers dependency and updated tests to run with containerized DBs.
Expanded test scope to include MySQL and MariaDB versions to cover conditional test cases.
Result:
Improved test suite stability and simplified setup for contributors. Resolves #76