Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply TestContainer #264

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Apply TestContainer #264

merged 1 commit into from
Apr 4, 2024

Conversation

jchrys
Copy link
Collaborator

@jchrys jchrys commented Mar 16, 2024

Motivation:
Enhance test reliability and environment consistency by integrating TestContainers

Modification:
Added TestContainers dependency and updated tests to run with containerized DBs.

Expanded test scope to include MySQL and MariaDB versions to cover conditional test cases.

Result:
Improved test suite stability and simplified setup for contributors. Resolves #76

@jchrys jchrys added bug Something isn't working enhancement New feature or request labels Mar 16, 2024
@jchrys jchrys added this to the 1.1.3 milestone Mar 16, 2024
@jchrys
Copy link
Collaborator Author

jchrys commented Mar 16, 2024

I added the bug label because the absence of fine-grained database versioning fails to cover conditional test cases.

@jchrys
Copy link
Collaborator Author

jchrys commented Mar 16, 2024

This PR is in very early phase of the changes

@jchrys
Copy link
Collaborator Author

jchrys commented Mar 22, 2024

TODO

  • determine serverType(mariadb, mysql) and its version by connection context. (may utilize mysqlconnector-j and mariadb connector)

@jchrys
Copy link
Collaborator Author

jchrys commented Mar 31, 2024

TODO

  • JavaDoc

@jchrys jchrys force-pushed the 1x-tc branch 2 times, most recently from 0385f0b to c2ae9a5 Compare April 2, 2024 19:11
@jchrys jchrys changed the title [DRAFT]Apply TestContainer Apply TestContainer Apr 2, 2024
@jchrys jchrys marked this pull request as ready for review April 2, 2024 19:13
@jchrys jchrys requested a review from mirromutth April 2, 2024 19:13
@jchrys jchrys force-pushed the 1x-tc branch 2 times, most recently from f5de078 to b47dbf1 Compare April 2, 2024 19:46
@jchrys jchrys force-pushed the 1x-tc branch 2 times, most recently from 4a9e8f3 to 9eaa3c5 Compare April 3, 2024 11:48
Motivation:
Enhance test reliability and environment consistency by integrating TestContainers

Modification:
Added TestContainers dependency and updated tests to run with containerized DBs.

Expanded test scope to include MySQL and MariaDB versions to cover conditional test cases.

Result:
Improved test suite stability and simplified setup for contributors.
Resolves #76
---------

Co-authored-by: saurabhyadav1985 <[email protected]>
Co-authored-by: Mirro Mutth <[email protected]>
Copy link
Contributor

@mirromutth mirromutth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jchrys jchrys merged commit 52bc71f into trunk Apr 4, 2024
26 checks passed
@jchrys jchrys deleted the 1x-tc branch April 4, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]Request to use Testcontainers for R2DBC MySQL Integration Testing
2 participants