Feat/time reserve battery triggering #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atbore-phx
force-pushed
the
feat/time-rerve-battery-triggering
branch
from
5f5ab16 to
c98ceae
Compare
atbore-phx
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v1.4.0 #56 +/- ##
===============================================
Coverage 98.70% 98.70%
===============================================
Files 10 10
Lines 309 309
===============================================
Hits 305 305
Misses 4 4 ☔ View full report in Codecov by Sentry. |
atbore-phx
force-pushed
the
feat/time-rerve-battery-triggering
branch
from
c98ceae to
c2a683e
Compare
Closed
atbore-phx
force-pushed
the
feat/time-rerve-battery-triggering
branch
from
9715278 to
c70e4a3
Compare
atbore-phx
force-pushed
the
feat/time-rerve-battery-triggering
branch
from
126cc2d to
14dc7fe
Compare
atbore-phx
added a commit
that referenced
this pull request
Jan 22, 2025
* feat(init): init release v1.4.0 * feat(fronius::schedule): Net power available is derived from the reserve rather than the actual battery capacity (#55) * Feat/time reserve battery triggering (#56) * feat(fronius::schedule): The reserve battery is now charged based on time * feat(params): tuning parameters * feat(doc): adding doc * feat(ha): fixing regexp * Update DOCS.md * fix(ha): adding start and end battery reserve hours for export * feat(fronius::schedule): Adding hysteresis logic when charging (#57) * feat(fronius::schedule): Adding hysteresis logic when charging * fix(doc): adding doc * Update DOCS.md * fix(test): fix test build script dir * fix(forecast): if forecast site is unavailable disable forecast charging only (#58)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #47
These will be exposed in the add-on configuration to allow customization.
For every crontab occurrence t, if the PW_battery_reserve is not met, SBAM will charge the reserve only when:
start_hr <= PW_battery_reserve_charge_start_hr <= t <= PW_battery_reserve_charge_end_hr <= end_hr.