Fix/solcast unavailable #58
Merged
+30
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v1.4.0 #58 +/- ##
===============================================
Coverage 98.70% 98.71%
===============================================
Files 10 10
Lines 310 311 +1
===============================================
+ Hits 306 307 +1
Misses 4 4 ☔ View full report in Codecov by Sentry. |
atbore-phx
added a commit
that referenced
this pull request
Jan 22, 2025
* feat(init): init release v1.4.0 * feat(fronius::schedule): Net power available is derived from the reserve rather than the actual battery capacity (#55) * Feat/time reserve battery triggering (#56) * feat(fronius::schedule): The reserve battery is now charged based on time * feat(params): tuning parameters * feat(doc): adding doc * feat(ha): fixing regexp * Update DOCS.md * fix(ha): adding start and end battery reserve hours for export * feat(fronius::schedule): Adding hysteresis logic when charging (#57) * feat(fronius::schedule): Adding hysteresis logic when charging * fix(doc): adding doc * Update DOCS.md * fix(test): fix test build script dir * fix(forecast): if forecast site is unavailable disable forecast charging only (#58)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#52
disable forecast charging only if forecast service is unavailable