Add support for formatting ports #1474
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a missing clause to handle port terms in `memory_estimate_usage(term)` function that is necessary for formatting ports for io or other purposes. Signed-off-by: Winford <[email protected]>
Add support for io_lib (and io, etc...) to format ports. Adds port_to_list/1 to erlang module exports to keep dialyzer happy. Signed-off-by: Winford <[email protected]>
UncleGrumpy
force-pushed
the
format_ports
branch
from
147776b to
0764fb0
Compare
pguyot
reviewed
Jan 16, 2025
| @@ -292,6 +292,8 @@ format_spw(_Format, T) when is_float(T) -> | |||
| erlang:float_to_list(T); | |||
| format_spw(_Format, T) when is_pid(T) -> | |||
| erlang:pid_to_list(T); | |||
| format_spw(_Format, T) when is_port(T) -> | |||
| erlang:port_to_list(T); | |||
There was a problem hiding this comment.
Thank you so much.
Could we have a test for this clause that passes on both BEAM and AtomVM?
open_port({spawn, "echo"}, []) works on both platforms AFAIK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for io_lib (and io, etc...) to format ports.
Adds port_to_list/1 to erlang module exports to keep dialyzer happy.
Adds a missing clause to handle port terms in
memory_estimate_usage(term)function that is necessary for formatting ports for io or other purposes.These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later