Make sub-binaries of sub-binaries sub-binaries #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bettio
approved these changes
Oct 28, 2023
bettio
requested changes
Oct 29, 2023
There was a problem hiding this comment.
Looks good, but it keeps failing on build-and-test (ubuntu-20.04, gcc-10, -m32 -O3, 23, g++-10, 1.11, -DOPENSSL_CRYPTO_LIBRARY=...
|
It fails on all 32 bits implementation. |
Fix a bug where sub-binaries of sub-binaries were reallocated, thus wasting memory. Signed-off-by: Paul Guyot <[email protected]>
pguyot
force-pushed
the
w43/subbinary-of-subbinary
branch
from
dcc47d3 to
3e475d8
Compare
|
This was a typo where a 7 was changed into 47 for no good reason, and this broke the test on 32 bits as the binary is only 32 bytes there which is smaller than 47. |
bettio
added a commit
to bettio/AtomVM-fork
that referenced
this pull request
Oct 29, 2023
Make sub-binaries of sub-binaries sub-binaries Fix a bug where sub-binaries of sub-binaries were reallocated, thus wasting memory. These changes are made under both the "Apache 2.0" and the "GNU Lesser General Public License 2.1 or later" license terms (dual license). SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later
bettio
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where sub-binaries of sub-binaries were reallocated, thus wasting memory.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later