Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReversingLabs Workflow (Don't Merge) #782

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

developerkunal
Copy link
Contributor

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Describe the purpose of this PR along with any background information and the impacts of the proposed change. For the benefit of the community, please do not assume prior context.

Provide details that support your chosen implementation, including: breaking changes, alternatives considered, changes to the API, etc.

If the UI is being changed, please provide screenshots.

References

Include any links supporting this change such as a:

  • GitHub Issue/PR number addressed or fixed
  • Auth0 Community post
  • StackOverflow post
  • Support forum thread
  • Related pull requests/issues from other repos

If there are no references, simply delete this section.

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

Copy link

github-actions bot commented Jul 2, 2024

/hold

2 similar comments
Copy link

github-actions bot commented Jul 2, 2024

/hold

Copy link

github-actions bot commented Jul 2, 2024

/hold

Copy link

github-actions bot commented Jul 2, 2024

/hold

1 similar comment
Copy link

github-actions bot commented Jul 2, 2024

/hold

@developerkunal developerkunal marked this pull request as ready for review October 21, 2024 11:16
@developerkunal developerkunal requested a review from a team as a code owner October 21, 2024 11:16
tusharpandey13
tusharpandey13 previously approved these changes Oct 21, 2024
--artifact "${{ inputs.artifact-path }}" \
--name "${{ github.event.repository.name }}" \
--version "${{ inputs.version }}" \
--repository "${{ inputs.repository }}" \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than requiring this to be passed in via a param, would it make sense just to use the default Actions var GITHUB_REPOSITORY ?

assuming this is a local action, so effectively it will only ever be publishing for auth0-react.

- name: Install Python dependencies
shell: bash
run: |
pip install --upgrade pip

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be necessary, considering you just ran the install with the Python actions. You'll see your workflow also indicates,

Requirement already satisfied: pip in /opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages (24.2)

So I'd suggest to remove this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! will remove this.

.github/workflows/release.yml Show resolved Hide resolved
@developerkunal developerkunal force-pushed the Add-ReversingLabs-Scanner branch from 645853c to 29d30db Compare October 30, 2024 12:21
arpit-jn
arpit-jn previously approved these changes Oct 30, 2024
@developerkunal developerkunal merged commit 6429fdd into main Oct 31, 2024
9 of 11 checks passed
@developerkunal developerkunal deleted the Add-ReversingLabs-Scanner branch October 31, 2024 10:35
@tusharpandey13 tusharpandey13 mentioned this pull request Jan 21, 2025
tusharpandey13 added a commit that referenced this pull request Jan 21, 2025
**Added**
- Feature/react19 [\#824](#824)
([tusharpandey13](https://github.com/tusharpandey13))
- Add ReversingLabs Workflow (Don't Merge)
[\#782](#782)
([developerkunal](https://github.com/developerkunal))

**Changed**
- Bump next from 13.5.6 to 14.1.1 in /examples/nextjs-app
[\#761](#761)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump @testing-library/react from 14.1.2 to 14.3.1
[\#757](#757)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump ts-jest from 29.1.1 to 29.1.5
[\#766](#766)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump cypress from 13.6.1 to 13.12.0
[\#770](#770)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump braces from 3.0.2 to 3.0.3
[\#773](#773)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump @types/jest from 29.5.11 to 29.5.12
[\#750](#750)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump @types/react from 18.2.45 to 18.2.64
[\#747](#747)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump browserstack-cypress-cli from 1.28.0 to 1.28.1
[\#715](#715)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump typedoc from 0.25.4 to 0.25.7
[\#713](#713)
([dependabot[bot]](https://github.com/apps/dependabot))

**Fixed**
- ci: changed pull_request_target to pull_request and removed the
authorize step [\#796](#796)
([desusai7](https://github.com/desusai7))
- Update codeowner file with new GitHub team name
[\#790](#790)
([stevenwong-okta](https://github.com/stevenwong-okta))
- Bump jose from 4.11.0 to 4.15.5 in /examples/users-api
[\#749](#749)
([dependabot[bot]](https://github.com/apps/dependabot))
- Workaround for failing "integration test (CRA)"
[\#769](#769)
([nandan-bhat](https://github.com/nandan-bhat))

**Security**
- Bump pretty-quick from 3.1.3 to 3.3.1
[\#736](#736)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump express from 4.18.2 to 4.19.2 in /examples/users-api
[\#754](#754)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump follow-redirects from 1.15.3 to 1.15.6
[\#752](#752)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump ws from 7.5.9 to 7.5.10
[\#768](#768)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump oidc-provider from 8.4.3 to 8.4.5
[\#720](#720)
([dependabot[bot]](https://github.com/apps/dependabot))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants