Call done callback once Arkose is ready #1433
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Call done callback inside Arkose's onReady callback to ensure Arkose is properly loaded. This'll help address the issue of Arkose taking a while to load and callers can rely on it to be sure when Arkose is fully loaded. Other captcha providers don't have a similar onReady callback so done call was moved to right after initialization.
https://developer.arkoselabs.com/docs/callbacks
References
https://auth0team.atlassian.net/browse/IAMRISK-3458
Testing
I tested this by setting a timeout to simulate the delay in Arkose loading. Here's a before and after comparison.
before.mov
after.mov
Checklist