Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the expected result for update portgroup #6082

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Update the expected result for update portgroup #6082

wants to merge 1 commit into from

Conversation

yalzhang
Copy link
Contributor

@yalzhang yalzhang commented Dec 20, 2024 •
edited
Loading

The expected result for update interface portgroup is not supported now, update the script accordingly.

@yalzhang
Update the expected result for update portgroup
3c6dda6 
Per bug https://issues.redhat.com/browse/RHEL-7299, the expected result
for update interface portgroup is changed. It is not supported to update
the portgroup now.

Signed-off-by: Yalan Zhang <[email protected]>
@yalzhang
Copy link
Contributor Author

before the fix
Command '/bin/virsh update-device avocado-vt-vm1 /var/tmp/xml_utils_temp_q_3trt1x.xml ' failed. stdout: b'\n' stderr: b'error: Failed to update device from /var/tmp/xml_utils_temp_q_3trt1x.xml\nerror: Operation not supported: cannot modify network device portgroup attribute\n' additional_info: None

after
(1/3) type_specific.io-github-autotest-libvirt.virtual_network.update_device.iface_portgroup.qos.nat: STARTED
(1/3) type_specific.io-github-autotest-libvirt.virtual_network.update_device.iface_portgroup.qos.nat: PASS (15.94 s)
(2/3) type_specific.io-github-autotest-libvirt.virtual_network.update_device.iface_portgroup.qos.linux_br: STARTED
(2/3) type_specific.io-github-autotest-libvirt.virtual_network.update_device.iface_portgroup.qos.linux_br: PASS (37.87 s)
(3/3) type_specific.io-github-autotest-libvirt.virtual_network.update_device.iface_portgroup.qos.ovs_br: STARTED
(3/3) type_specific.io-github-autotest-libvirt.virtual_network.update_device.iface_portgroup.qos.ovs_br: PASS (51.02 s)

chunfuwen
chunfuwen approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@chunfuwen chunfuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yalzhang
Copy link
Contributor Author

yalzhang commented Jan 6, 2025

Please hold on since we need dev's double confirmation. Thanks.

@Yingshun Yingshun marked this pull request as draft January 7, 2025 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunfuwen chunfuwen chunfuwen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yalzhang @chunfuwen