fix(image_projection_based_fusion): add arg data_path, update model_path #5163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexey Panferov <[email protected]>
github-actions
bot
added
the
component:perception
38 tasks
miursh
added
the
run:build-and-test-differential
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5163 +/- ##
==========================================
- Coverage 14.91% 14.88% -0.04%
==========================================
Files 1625 1630 +5
Lines 112419 112656 +237
Branches 34703 34703
==========================================
Hits 16769 16769
- Misses 76903 77140 +237
Partials 18747 18747
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yukke42
approved these changes
Sep 28, 2023
lexavtanke
deleted the
fix-image-projection-based-fusion-update-model-path
branch
miursh
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 28, 2023
…ath (autowarefoundation#5163) Signed-off-by: Alexey Panferov <[email protected]>
7 tasks
This was referenced Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Belongs to Standardize a strategy for packages with downloaded artifacts
As autowarefoundation/autoware#3375 was merged to Autoware.universe. It is possible to use artifacts downloaded there.
#4904 was merged and old path to model file is outdated.
This PR introduces new launch argument data_path in the form:
<arg name="data_path" default="$(env HOME)/autoware_data" description="packages data and artifacts directory path"/>It updates model_path arg as well.
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.