feat(map_loader, route_handler)!: add format_version validation #7074
CodeScene PR Check
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: +0.07 (3.14 -> 3.20)
- Declining Code Health: 2 findings(s) 🚩
Details
🚩 Declining Code Health (highest to lowest):
- Complex Conditional lanelet2_map_loader_node.cpp: Lanelet2MapLoaderNode::on_map_projector_info
- Bumpy Road Ahead lanelet2_map_loader_node.cpp: Lanelet2MapLoaderNode::on_map_projector_info
Annotations
Check notice on line 117 in map/map_loader/src/lanelet2_map_loader/lanelet2_map_loader_node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ New issue: Complex Method
Lanelet2MapLoaderNode::on_map_projector_info has a cyclomatic complexity of 12, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 92 in map/map_loader/src/lanelet2_map_loader/lanelet2_map_loader_node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Conditional
Lanelet2MapLoaderNode::on_map_projector_info has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
Check warning on line 117 in map/map_loader/src/lanelet2_map_loader/lanelet2_map_loader_node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
Lanelet2MapLoaderNode::on_map_projector_info has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check notice on line 1 in planning/autoware_route_handler/src/route_handler.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Lines of Code in a Single File
The lines of code increases from 1848 to 1858, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
Check notice on line 1 in planning/autoware_route_handler/src/route_handler.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 4.66 to 4.68, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.