feat(autoware_traffic_light_multi_camera_fusion): Created Schema file and updated ReadME file for parameters setting #9994
+58
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and updated ReadME file for parameters setting Signed-off-by: vish0012 <[email protected]>
vish0012
requested review from
MasatoSaeki,
miursh and
tzhong518
as code owners
github-actions
bot
added
type:documentation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
MasatoSaeki
added
the
run:deploy-docs
MasatoSaeki
reviewed
Jan 21, 2025
There was a problem hiding this comment.
@vish0012
Thank you for your PR. Could you please check my comments?
| @@ -150,7 +150,7 @@ MultiCameraFusion::MultiCameraFusion(const rclcpp::NodeOptions & node_options) | |||
| std::vector<std::string> camera_namespaces = | |||
| this->declare_parameter("camera_namespaces", std::vector<std::string>{}); | |||
| is_approximate_sync_ = this->declare_parameter<bool>("approximate_sync", false); | |||
There was a problem hiding this comment.
Suggested change
| is_approximate_sync_ = this->declare_parameter<bool>("approximate_sync", false); | |
| is_approximate_sync_ = this->declare_parameter<bool>("approximate_sync"); |
| @@ -150,7 +150,7 @@ MultiCameraFusion::MultiCameraFusion(const rclcpp::NodeOptions & node_options) | |||
| std::vector<std::string> camera_namespaces = | |||
| this->declare_parameter("camera_namespaces", std::vector<std::string>{}); | |||
There was a problem hiding this comment.
Suggested change
| this->declare_parameter("camera_namespaces", std::vector<std::string>{}); | |
| this->declare_parameter<std::vector<std::string>>("camera_namespaces"); |
Comment on lines
+27
to
+31
| "perform_group_fusion": { | ||
| "type": "boolean", | ||
| "description": "Whether to perform Group Fusion.", | ||
| "default": false | ||
| } |
There was a problem hiding this comment.
Suggested change
| "perform_group_fusion": { | |
| "type": "boolean", | |
| "description": "Whether to perform Group Fusion.", | |
| "default": false | |
| } |
This parameter is not used. So delete it
There was a problem hiding this comment.
And could you delete perform_group_fusion in ***.param.yaml too?
Comment on lines
+33
to
+38
| "required": [ | ||
| "camera_namespaces", | ||
| "message_lifespan", | ||
| "approximate_sync", | ||
| "perform_group_fusion" | ||
| ], |
There was a problem hiding this comment.
Suggested change
| "required": [ | |
| "camera_namespaces", | |
| "message_lifespan", | |
| "approximate_sync", | |
| "perform_group_fusion" | |
| ], | |
| "required": [ | |
| "camera_namespaces", | |
| "message_lifespan", | |
| "approximate_sync", | |
| ], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the autoware_traffic_light_multi_camera_fusion package.
create json shema
update readme file
deleted default value
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.