Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(map_loader, route_handler)!: add format_version validation #993

Conversation

soblin
Copy link
Contributor

@soblin soblin commented May 20, 2024

Description

autowarefoundation/autoware.universe#7074

Related links

Tests performed

see autowarefoundation/autoware.universe#7074

Notes for reviewers

Interface changes

see autowarefoundation/autoware.universe#7074

Effects on system behavior

see autowarefoundation/autoware.universe#7074

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@soblin soblin force-pushed the feat/map_loader_format_version_validation branch from 65da48f to 91b74c3 Compare June 12, 2024 05:20
@soblin soblin changed the title feat!(map_loader): add format_version validation feat!(map_loader, route_handler): add format_version validation Jun 12, 2024
@YamatoAndo YamatoAndo changed the title feat!(map_loader, route_handler): add format_version validation feat(map_loader, route_handler)!: add format_version validation Jun 17, 2024
@YamatoAndo YamatoAndo changed the title feat(map_loader, route_handler)!: add format_version validation feat(map_loader, route_handler)!: add format_version validation Jun 17, 2024
Signed-off-by: Mamoru Sobue <[email protected]>
@soblin soblin force-pushed the feat/map_loader_format_version_validation branch from f008d48 to 82e157d Compare July 5, 2024 05:40
@soblin soblin merged commit 2a965cd into autowarefoundation:main Jul 9, 2024
13 checks passed
@soblin soblin deleted the feat/map_loader_format_version_validation branch July 9, 2024 13:43
shmpwk pushed a commit to tier4/autoware_launch that referenced this pull request Jul 21, 2024
…warefoundation#993)

feat(map_loader): add format_version validation

Signed-off-by: Mamoru Sobue <[email protected]>
Ericpotato added a commit to tier4/autoware_launch that referenced this pull request Nov 6, 2024
… when using psim (autowarefoundation#993)

* sync diagnostic_graph_aggregator configs, remove sensing and harware from monitoring list

Signed-off-by: Ericpotato <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Ericpotato <[email protected]>
Co-authored-by: Ericpotato <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:map Map creation, storage, and loading. (auto-assigned) run:build-and-test-differential
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants