redesign sdlf-team and sdlf-dataset #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Design change: sdlf-team is no longer involved with data encryption, this is now specific to datasets. sdlf-team still exists, as a consumption module, currently focused on athena. having encryption per dataset is better in the sharing use case - no need to grant access to an entire team's kms keys for access to a single dataset
go hand-in-hand with the previous change on sdlf-dataset
This was referenced Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
sdlf-datasetas catalog module,sdlf-teamas consumption module.sdlf-team is no longer involved with data encryption, this is now specific to datasets. sdlf-team still exists, as a consumption module, currently focused on Athena. Having encryption per dataset is better in the sharing use case - no need to grant access to an entire team's kms keys for access to a single dataset.
Move around a couple DynamoDB tables and decommission most of them as part of this change - they were mostly leftover from the old Octagon compatibility, and that is not very alive nowadays.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.