Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(minor-service-registry): add client for queries #600

Merged
merged 4 commits into from
Sep 5, 2024
Merged

feat(minor-service-registry): add client for queries #600

merged 4 commits into from
Sep 5, 2024

Conversation

cjcobb23
Copy link
Contributor

@cjcobb23 cjcobb23 commented Aug 28, 2024 •
edited
Loading

@cjcobb23 cjcobb23 requested a review from a team as a code owner August 28, 2024 19:18
@codecov Codecov
Copy link

codecov bot commented Aug 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.80240% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.70%. Comparing base (21d386d) to head (7786d5b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
contracts/service-registry/src/client.rs 98.80% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #600      +/-   ##
==========================================
+ Coverage   93.67%   93.70%   +0.02%     
==========================================
  Files         220      221       +1     
  Lines       31097    31264     +167     
==========================================
+ Hits        29130    29295     +165     
- Misses       1967     1969       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cgorenflo
cgorenflo reviewed Sep 4, 2024
View reviewed changes
contracts/service-registry/src/client.rs Outdated Show resolved Hide resolved
contracts/service-registry/src/client.rs Outdated Show resolved Hide resolved
contracts/service-registry/src/client.rs Show resolved Hide resolved
contracts/service-registry/src/client.rs Outdated Show resolved Hide resolved
@cjcobb23 cjcobb23 merged commit 67a4ce2 into main Sep 5, 2024
8 checks passed
@cjcobb23 cjcobb23 deleted the service_registry_query_client branch September 5, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgorenflo cgorenflo cgorenflo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjcobb23 @cgorenflo