Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(minor-ampd): stellar verifier set verifier #617

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

haiyizxx
Copy link
Contributor

@haiyizxx haiyizxx commented Sep 10, 2024

Description

AXE-4640

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues

Steps to Test

Expected Behaviour

Other Notes

@haiyizxx haiyizxx force-pushed the stellar-verify-signer-rotation branch from 8b60fb7 to 74ff448 Compare September 10, 2024 21:37
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 91.86603% with 34 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@0da965d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
ampd/src/lib.rs 0.00% 14 Missing ⚠️
ampd/src/stellar/http_client.rs 0.00% 11 Missing ⚠️
ampd/src/handlers/stellar_verify_verifier_set.rs 97.94% 4 Missing ⚠️
ampd/src/stellar/verifier.rs 98.24% 3 Missing ⚠️
ampd/src/handlers/config.rs 85.71% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #617   +/-   ##
=======================================
  Coverage        ?   93.66%           
=======================================
  Files           ?      234           
  Lines           ?    33322           
  Branches        ?        0           
=======================================
  Hits            ?    31210           
  Misses          ?     2112           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haiyizxx haiyizxx marked this pull request as ready for review September 10, 2024 21:42
@haiyizxx haiyizxx requested a review from a team as a code owner September 10, 2024 21:43
ampd/src/handlers/config.rs Show resolved Hide resolved
@haiyizxx haiyizxx merged commit 2d4a99c into main Sep 11, 2024
8 checks passed
@haiyizxx haiyizxx deleted the stellar-verify-signer-rotation branch September 11, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants