Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(axelar-wasm-std-minor): derive macro into-event support generics #736

Closed

Conversation

fish-sammy
Copy link
Collaborator

@fish-sammy fish-sammy commented Jan 7, 2025

Description

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues

Steps to Test

Expected Behaviour

Other Notes

@fish-sammy fish-sammy requested a review from a team as a code owner January 7, 2025 06:25
@fish-sammy fish-sammy force-pushed the feat/derive-macro-into-event-support-generics branch from 3585426 to f46d785 Compare January 7, 2025 06:26
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 99.42857% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.71%. Comparing base (a7cb956) to head (af72747).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
ampd/src/handlers/mvx_verify_verifier_set.rs 99.16% 2 Missing ⚠️
packages/axelar-wasm-std-derive/src/lib.rs 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #736      +/-   ##
==========================================
- Coverage   93.72%   93.71%   -0.02%     
==========================================
  Files         222      222              
  Lines       36175    36174       -1     
==========================================
- Hits        33905    33900       -5     
- Misses       2270     2274       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fish-sammy fish-sammy force-pushed the feat/derive-macro-into-event-support-generics branch 4 times, most recently from ca80570 to 58600b2 Compare January 8, 2025 06:19
@fish-sammy fish-sammy force-pushed the feat/derive-macro-into-event-support-generics branch from b75ad04 to 75f468d Compare January 9, 2025 18:38
@fish-sammy fish-sammy changed the base branch from main to refactor/improve-voting-verifier-event-tests January 9, 2025 18:38
@fish-sammy fish-sammy force-pushed the feat/derive-macro-into-event-support-generics branch from 0cfbd28 to 75f468d Compare January 9, 2025 18:39
@fish-sammy fish-sammy force-pushed the feat/derive-macro-into-event-support-generics branch 3 times, most recently from 896e4dc to 11e36af Compare January 9, 2025 18:53
@fish-sammy fish-sammy force-pushed the feat/derive-macro-into-event-support-generics branch from 11e36af to af72747 Compare January 9, 2025 20:35
@fish-sammy fish-sammy marked this pull request as draft January 9, 2025 21:25
Base automatically changed from refactor/improve-voting-verifier-event-tests to main January 9, 2025 21:40
@fish-sammy fish-sammy closed this Jan 10, 2025
@fish-sammy fish-sammy deleted the feat/derive-macro-into-event-support-generics branch January 10, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant