Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsync-tls - fails to sync if many files in the root of the source PVC #1290

Closed
tesshuflower opened this issue Jun 4, 2024 · 0 comments · Fixed by #1291
Closed

rsync-tls - fails to sync if many files in the root of the source PVC #1290

tesshuflower opened this issue Jun 4, 2024 · 0 comments · Fixed by #1291
Assignees
Labels
bug Something isn't working

Comments

@tesshuflower
Copy link
Contributor

Describe the bug

Rsync-tls uses globbing to get the file list to send to the destination, both these cmds can fail with Arguments list too long error if there are too many files (or filenames too long) for files/directories in the root directory of the source PVC.

if [[ -n "$(ls -A -- ${SOURCE}/*)" ]]; then

/mover-rsync-tls/client.sh: line 115: /usr/bin/ls: Argument list too long

Which can manifest in the client script thinking there are no files to sync

and

rsync -aAhHSxz --exclude=lost+found --itemize-changes --info=stats2,misc2 ${SOURCE}/* rsync://127.0.0.1:$STUNNEL_LISTEN_PORT/data

Can produce the error:

/mover-rsync-tls/client.sh: line 117: /usr/bin/rsync: Argument list too long

which will result in the sync failing and repeatedly retrying.

The above log statements were taken from a v0.8.1 build.

Steps to reproduce

Expected behavior

Actual results

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant