-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rsync tls toomanyfiles #1291
Rsync tls toomanyfiles #1291
Conversation
Signed-off-by: Tesshu Flower <[email protected]>
- doing ls -A /data/* will produce error "Argument list too long" with the data used in this test Signed-off-by: Tesshu Flower <[email protected]>
Quality Gate passedIssues Measures |
/cc @JohnStrunk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnStrunk, tesshuflower The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override DCO |
@JohnStrunk: Overrode contexts on behalf of JohnStrunk: DCO In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Rsync tls toomanyfiles (cherry picked from commit 3ebf860)
Rsync tls toomanyfiles (cherry picked from commit 3ebf860)
Rsync tls toomanyfiles (cherry picked from commit 3ebf860) Signed-off-by: Tesshu Flower <[email protected]>
Rsync tls toomanyfiles (cherry picked from commit 3ebf860) Signed-off-by: Tesshu Flower <[email protected]>
Describe what this PR does
Fixes rsync-tls issue with argments too long when many files are in the root of the source PVC
Is there anything that requires special attention?
--files-from
arg to rsync-r
flag to rsync (this flag is normally implied by-a
, but gets turned off by default when using--files-from
)Related issues:
Fixes: #1290